Allow load_ui to load local files #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o global dir. This allows load_ui to be used by custom tools built by users.
|
+1 |
|
Ok, merging! |
astrofrog
added a commit
that referenced
this pull request
Mar 30, 2015
Allow load_ui to load local files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this approach,
load_uifirst checks if the file exists at the path specified, and if not, falls back to the one in the global glue directory. This allowsload_uito be used by external plugins.Another option is to add a keyword argument that says
in_global_ui, defaults toFalse, and gets set toTrueeverywhereload_uiis used inside glue. That was the approach in #552.@ChrisBeaumont - what do you think?